Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): remove dotted outline on select element #3593

Merged
merged 2 commits into from
Jul 30, 2019

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Jul 30, 2019

Closes #1526

Removes dotted line outline on select element in Firefox

Testing

Ensure no dotted line shows up on select

@tw15egan tw15egan requested a review from a team July 30, 2019 19:20
@ghost ghost requested review from aledavila and dakahn July 30, 2019 19:20
@ghost ghost removed their request for review July 30, 2019 19:20
@netlify
Copy link

netlify bot commented Jul 30, 2019

Deploy preview for the-carbon-components ready!

Built with commit e559354

https://deploy-preview-3593--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jul 30, 2019

Deploy preview for carbon-elements ready!

Built with commit e559354

https://deploy-preview-3593--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jul 30, 2019

Deploy preview for carbon-components-react ready!

Built with commit e559354

https://deploy-preview-3593--carbon-components-react.netlify.com

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 - Thanks @tw15egan!

@asudoh asudoh merged commit 94119f9 into carbon-design-system:master Jul 30, 2019
@tw15egan tw15egan deleted the select-firefox branch March 3, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox dotted inner focus should be removed from all elements where we define a custom focus state
3 participants